Replace ansible.module_utils.six.moves.urllib_parse with stdlib urllibparse - #291
Conversation
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @chynasan. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
alinabuzachis
left a comment
alinabuzachis
left a comment
There was a problem hiding this comment.
Can you also please add a changelog fragment?
abikouo
added
ok-to-test
openshift-ci
Bot
added
lgtm
|
@oraNod: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abikouo, chynasan, oraNod The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@chynasan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Small update to imports.
As requested by @oraNod in #286